-
-
Notifications
You must be signed in to change notification settings - Fork 502
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
Links in dietpi-software changed from phpBB to dietpi.com/docs #4042
Conversation
Links were changed. @MichaIng: Open point: The mechanism with "readonly FP_ONLINEDOC_URL='https://dietpi.com/phpbb/viewtopic.php?'" (see line 258 in dietpi-software.sh) need also to be changed to direct to dietpi.com/docs instead of phpBB.
This will impact each and every software title as there is a link on each software title OnlineDocs are shown on command line
|
What do you think:
|
Option 2 might be more clear indeed. |
Are you okay with the small changes I did? I think it's okay to show one install docs URL only, the other one is the next/belog page anyway. It's a bit strange to link install documentation at a stage where DietPi has been installed already. Probably it makes more sense to link the DietPi-Software documentation itself? https://dietpi.com/docs/dietpi_tools/#dietpi-software I also switched the software list link to point to the new docs. In most cases this shortens the way of users to the information they seek. Not sure about the future of https://dietpi.com/dietpi-software.html, if it makes sense to maintain two lists forever, but that is a different topic. I'll open a new PR to replace the individual software docs URLs. |
Like Joulinar I also prefer option 2. |
Haha, many thanks for the "bid" => "bit" fix Stephan. I often see it myself now, probably 50% of cases, but hard to wean off such a long "learned" mistake 😄. |
Status: Ready
@MichaIng:
Open point: The mechanism with "readonly FP_ONLINEDOC_URL='https://dietpi.com/phpbb/viewtopic.php?'" (see line 258 in dietpi-software.sh) need also to be changed to direct to dietpi.com/docs instead of phpBB.